1024 is the default value of FD_SETSIZE i.e. the largest fd one can use with select(), so I think you have the right idea. Use of a magic constant might be reconsidered though. Could also convert the code to use poll() like Chicken core was some time ago. Jim
> On Feb 20, 2015, at 02:27, Christian Kellermann <ck...@pestilenz.org> wrote: > > Hi! > > Chaos Eternal <chaoseter...@shlug.org> writes: > >> uses a magic number 1024 , which used to pack master fd and slave fd >> into one integer to return. >> >> but why 1024 and what happens when the slave fd is greater than 1024? > > I am not the author but 1024 happens to be the default maximum number of > open files for most systems(tm). > > And yes if that assumption is wrong it will break and do strange things. > > As I see it it's just a quick hack to get both values out of C without > further FFI tricks. Maybe I am wrong and Alex can explain the rationale > behind it, if there is any. > > Kind regards, > > Christian > > -- > May you be peaceful, may you live in safety, may you be free from > suffering, and may you live with ease. > > > _______________________________________________ > Chicken-users mailing list > Chicken-users@nongnu.org > https://lists.nongnu.org/mailman/listinfo/chicken-users _______________________________________________ Chicken-users mailing list Chicken-users@nongnu.org https://lists.nongnu.org/mailman/listinfo/chicken-users
