Issue 2079: Dialog windows crash due to simultaneous 2-way dismissal
http://code.google.com/p/chromium/issues/detail?id=2079

New issue report by [EMAIL PROTECTED]:
Product Version      : 0.2.149.29 (1798)
URLs (if applicable) :
Other browsers tested:
   Add OK or FAIL after other browsers where you have tested this issue:
      Safari 3: NA
     Firefox 3: OK
          IE 7: OK

What steps will reproduce the problem?
1. Run script like <script>alert('');</script>
2. Focus the OK button and press it with a space bar (but do not release  
it).
3. Press ESC.

What is the expected result?

Dialog window is dismissed.

What happens instead?

First, DialogClientView::AcceptWindow() is fired by VK_ESC accelerator.
The dismissal procedure starts, but the window still waits for WM_CLOSE.
(I've seen a comment somewhere in the code that it is like that to simplify  
the code, i. e. have only
one path for destroying a dialog both by closing it with a cross and with  
an accelerator key).
Since OK button has already been pressed (WM_KEYDOWN has been sent), there  
goes WM_KEYUP which starts
the closing procedure for the second time. That causes NOTREACHED() in  
DialogClientView::AcceptWindow() to be fired.

Possible solution is to destroy the window right after we are told to do  
so, without sending WM_CLOSE
to ourselves...


Attachments:
        test.html  28 bytes


Issue attributes:
        Status: Unconfirmed
        Owner: [EMAIL PROTECTED]
        Labels: Type-Bug Pri-2 OS-All Area-Unknown

-- 
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings

--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups 
"Chromium-bugs" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at 
http://groups.google.com/group/chromium-bugs?hl=en
-~----------~----~----~----~------~----~------~--~---

Reply via email to