Issue 3007: Mouse click layout tests fail http://code.google.com/p/chromium/issues/detail?id=3007
Comment #2 by [EMAIL PROTECTED]: Fixed in revision 2917 Log: This fixes http://code.google.com/p/chromium/issues/detail?id=3007, which is the mouse-click-events.html layout test failure. Fix as per below:- 1. The test shell mouse event generating mechanism now tracks the last mouse button number received. This is used to determine whether the click count continues to increment or not. 2. We now default to middle button if the button number passed in from js contains anything other than 0 or 2. This is as per the event sending mechanism in webkit mac. We still need to re-baseline this test as the number of events printed on the page cause a scrollbar to show up for the 4th mouse event test. This causes the middle mouse button to be eaten as per recent changes in EventHandler.cpp. Bug=3007 R=tony Review URL: http://codereview.chromium.org/6261 Added: trunk/src/webkit/data/layout_test_results/common/LayoutTests/fast/events/mouse- click-events-expected.txt (contents, props changed) Modified: trunk/src/webkit/tools/layout_tests/test_lists/tests_fixable.txt trunk/src/webkit/tools/test_shell/event_sending_controller.cc trunk/src/webkit/tools/test_shell/event_sending_controller.h Issue attribute updates: Status: Fixed -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Chromium-bugs" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/chromium-bugs?hl=en -~----------~----~----~----~------~----~------~--~---
