Comment #7 on issue 4203 by m0.interactive: When omnibox has focus and no
drop down, ESC should select the whole line
http://code.google.com/p/chromium/issues/detail?id=4203
Okay as pkasting stated in the review:
- I think hashing out something good is probably pointless given
- that I think we want to SelectAll() in more cases than just this
- one (i.e. just after calling RevertAll()), so the code needs to be
- rearchitected a tiny bit.
I have written down some actions that should be taken a look of and
where reselecting the whole text would be applicable. I found all
references of RevertAll and figuring out if we really need SelectAll
right after it.
Action: Every tab update from moving/creating/ and deleting tabs
Result: Nothing Selected
My Expected: [PASS] Nothing should be selected
Action: Navigating URL
Result: Nothing Selected
My Expected: [PASS] Nothing should be selected
Action: Omnibox out of focus, then re click once on the text
Result: Text Selected
My Expected: [PASS] Text Selected
Action: Arrowing down in dropdown box then Escape pressed
Result: Reverts back to original input, drop down still opened, Nothing
Selected
My Expected: [PASS] Revert back to original input, drop down should stay
opened, and
Nothing selected since we might choose another item
Action: Arrowing down in dropdown box then Escape pressed, then press
Escape again
Result: Reverts back to original input, drop down closed, Nothing Selected
My Expected: [FAIL] Revert back to original input, drop down closed,
then Select All input
Action: Escape pressed with no new input
Result: Nothing Selected
My Expected: [FAIL] The whole text should be selected
Action: Escape pressed with new input
Result: Reverts back to previous input, and Nothing Selected
My Expected: [FAIL] Revert back and Select All
That is what I expect to happen for Selecting All text. Do you agree to
these points?
--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"Chromium-bugs" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at
http://groups.google.com/group/chromium-bugs?hl=en
-~----------~----~----~----~------~----~------~--~---
