Comment #3 on issue 5650 by [email protected]: FilePath::IsPathAbsolute vs. file_util::AbsolutePath http://code.google.com/p/chromium/issues/detail?id=5650
If you want to differentiate Absolute from Canonical, then we should rename file_util::AbsolutePath to be file_util::CanonicalPath. Having two methods with the same name that behave differently is very confusing. I only noticed this because I was reviewing code that used both methods within a few lines of each other. Incidentally, part of the reason I suggested making IsPathAbsolute enforce canonical is that a number of other APIs conflate these two concepts into a single absolute path. One example is python os.path.abspath. I'm not sure that there's a large benefit to keeping the concepts separate. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Chromium-bugs" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [email protected] For more options, visit this group at http://groups.google.com/group/chromium-bugs?hl=en -~----------~----~----~----~------~----~------~--~---
