Comment #20 on issue 4334 by [email protected]: Crash when clicking
empty select element.
http://code.google.com/p/chromium/issues/detail?id=4334
The following revision refers to this bug:
http://src.chromium.org/viewvc/chrome?view=rev&revision=7347
------------------------------------------------------------------------
r7347 | [email protected] | 2008-12-20 10:42:15 -0800 (Sat, 20 Dec 2008) |
19 lines
Changed paths:
M
http://src.chromium.org/viewvc/chrome/trunk/src/webkit/port/platform/chromium/PopupMenuChromium.cpp?r1=7347&r2=7346
Fixed crash when clicking empty select element.
I believe this is not needed:
if (windowHeight == 0)
windowHeight = min(getRowHeight(-1), kMaxHeight);
windowHeight is dependent on the number of items within the popup, if you
have
no items within the popup, it returns 0. I don't understand why we need to
do
"min(getRowHeight(-1), kMaxHeight)" when its 0, that doesn't make sense to
me.
Since getRowHeight gets the height of that i...@index, everyone knows there
are
no item for index -1 (hence crash).
Patch by Mohamed Mansour
R=darin
BUG=4334 (http://crbug.com/4334)
TEST=<select></select>
------------------------------------------------------------------------
--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"Chromium-bugs" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to
[email protected]
For more options, visit this group at
http://groups.google.com/group/chromium-bugs?hl=en
-~----------~----~----~----~------~----~------~--~---
