Comment #18 on issue 5054 by [email protected]: [magic_browzr] Window
size/position wrong in XP maximized mode
http://code.google.com/p/chromium/issues/detail?id=5054
The following revision refers to this bug:
http://src.chromium.org/viewvc/chrome?view=rev&revision=7391
------------------------------------------------------------------------
r7391 | [email protected] | 2008-12-22 15:18:37 -0800 (Mon, 22 Dec
2008) | 13 lines
Changed paths:
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/frame/opaque_non_client_view.cc?r1=7391&r2=7390
Make Maximized Mode Not Suck, part 1 (checkpoint).
Pixel perfection (I think) on Normal and App windows, maximized and
restored, on Windows XP Luna with default fonts and border widths. Among
other things, fixes window control placement, tabstrip height, window
icon/title placement, and client edge drawing (especially at the
tops/bottoms of windows).
Known to still be broken: Popup windows
Untested: Vista non-Aero, Classic, non-default fonts/borders, non-main
windows (Options, Task Manager, etc.)
This change is pretty hacky in some places; once I get the behavior nailed
perfectly I'll need to go back and try and cut down on the number of
constants and use better logic instead. I do at least try to remove some
of the current hacks or else document them.
Eventually I'll need Ben's and Glen's eyeballs for things, as I've had to
make judgment calls about the correct behaviors; some of these I copied our
1.0 behavior, and some I've tried to ape a native app more closely.
Especially tricky are the positioning of window icons/titles, since our
titlebar isn't quite like a native one.
BUG=5054
Review URL: http://codereview.chromium.org/16219
------------------------------------------------------------------------
--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"Chromium-bugs" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to
[email protected]
For more options, visit this group at
http://groups.google.com/group/chromium-bugs?hl=en
-~----------~----~----~----~------~----~------~--~---
