Status: Assigned Owner: [email protected] CC: [email protected] Labels: Type-Bug Pri-2 OS-All Area-WebKit stable
New issue 5827 by [email protected]: Implement ImageSource::filenameExtension http://code.google.com/p/chromium/issues/detail?id=5827 We're failing a couple of tests because of the addition of an ASSERT to DragController.cpp, specifically: ASSERT(!image->filenameExtension().isEmpty()); Our ImageSource returns an empty string from filenameExtension, and we crash. Adam landed a patch upstream (revision 39396) that adds a filenameExtension method to ImageDecoder. Once we get this version of WebKit we need to change ImageSource::filenameExtension to: if (!m_decoder) return String(); return m_decoder->filenameExtension(); And hopefully the following layout tests will then pass again LayoutTests/editing/pasteboard/4947130.html LayoutTests/editing/pasteboard/drag-image-in-about-blank-frame.html LayoutTests/editing/pasteboard/drag-image-to-contenteditable-in-iframe.html LayoutTests/editing/pasteboard/drag-selected-image-to-contenteditable.html LayoutTests/editing/selection/drag-to-contenteditable-iframe.html LayoutTests/fast/events/standalone-image-drag-to-editable.html -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~---------~--~----~------------~-------~--~----~ Automated mail from issue updates at http://crbug.com/ Subscription options: http://groups.google.com/group/chromium-bugs -~----------~----~----~----~------~----~------~--~---
