Comment #3 on issue 5806 by [email protected]: Empty item in Omnibox dropdown when + is added to URL http://code.google.com/p/chromium/issues/detail?id=5806
This occurs for any query string when the suggest server returns the first result of google:suggesttype NAVIGATION and the URL does not include the http: prefix. The query that includes + causes the suggestion server not to return the original URL as a NAVIGATION suggestion result. The original URL is the only NAVIGATION suggestion result that appears to include the http: prefix. This seems to be an inconsistency with the suggestion server. For example, http://clients1.google.com/complete/search? client=chrome&output=chrome&hl=en&q=www.yahoo.com returns: ["www.yahoo.com",["http://www.yahoo.com/","www.yahoo.com mail","www.yahoo.com.au","www.yahoo.com.my"],["Yahoo!","68,400,000 results","",""],[],{"google:suggesttype":["NAVIGATION","QUERY","NAVIGATION","NAVIGATION"]}] The first suggest result of type NAVIGATION is "http://www.yahoo.com";. However, http://clients1.google.com/complete/search? client=chrome&output=chrome&hl=en&q=www.yahoo.com%2F%2B returns: ["www.yahoo.com/+",["www.yahoo.com mail","www.yahoo.com/","www.yahoo.com/finance","www.yahoo.com/music"],["68,400,000 results","","",""],[],{"google:suggesttype":["QUERY","NAVIGATION","NAVIGATION","NAVIGATION"]}] Now, the first NAVIGATION result is "www.yahoo.com/". In search_provider.cc:324, a GURL is constructed from this string. In the latter case, this GURL is invalid, and this invalid NavigationResult makes it all the way into the completion list as an empty string. Two possible fixes are: 1) Ignore any NAVIGATION result that yields an invalid URL (i.e. GURL::is_valid returns false). 2) Fix any NAVIGATION result that does not include a scheme to default to the http scheme. It seems like the second option is the better of the two, and so I'm attempting to put together a patch that will do this. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~---------~--~----~------------~-------~--~----~ Automated mail from issue updates at http://crbug.com/ Subscription options: http://groups.google.com/group/chromium-bugs -~----------~----~----~----~------~----~------~--~---
