Comment #6 on issue 3034 by [email protected]: \r cleanup
http://code.google.com/p/chromium/issues/detail?id=3034
ok, so trace_event is done.
The other place that has \r\n is json code in base (json_writer etc.). It
probably
should have \r\n on Win and \n on everything else, but this should be
somehow passed
to the unit test (in base, and in chrome/common). I see two ways:
- constant (I would put it in even some more generic header in base); but
concatenating it at every line of expected test output is not pretty
- #ifdefs, which are not pretty either
And the final question would be, do we want to change any other occurrences
of \r\n?
Here's what git grep '\\r\\n' | egrep '^base' gives me:
base/clipboard_util.cc: static const char* header = "Version:0.9\r\n"
base/clipboard_util.cc: "StartHTML:" NUMBER_FORMAT "\r\n"
base/clipboard_util.cc: "EndHTML:" NUMBER_FORMAT "\r\n"
base/clipboard_util.cc: "StartFragment:" NUMBER_FORMAT "\r\n"
base/clipboard_util.cc: "EndFragment:" NUMBER_FORMAT "\r\n";
base/clipboard_util.cc: "<html>\r\n<body>\r\n<!--StartFragment-->\r\n";
base/clipboard_util.cc: "\r\n<!--EndFragment-->\r\n</body>\r\n</html>";
base/clipboard_util.cc: result.append("\r\n");
base/clipboard_win.cc: const wchar_t* const kDelim = L"\r\n";
base/json_writer.cc:const char kPrettyPrintLineEnding[] = "\r\n";
base/json_writer_unittest.cc: ASSERT_EQ("{\r\n"
base/json_writer_unittest.cc: " \"list\": [ {\r\n"
base/json_writer_unittest.cc: " \"inner int\": 10\r\n"
base/json_writer_unittest.cc: " }, [ ], true ]\r\n"
base/json_writer_unittest.cc: "}\r\n",
base/logging.cc: str_newline.append("\r\n");
base/string_util_unittest.cc: output = L" This is a test \r\n";
base/string_util_unittest.cc: output = L" \r\n";
base/string_util_unittest.cc: {L" a \r b\n c \r\n d \t\re \t f \n ", true,
L"abcde f"},
base/string_util_unittest.cc: "0123ABCDwxyz \a\b\t\r\n!+,.~"
base/string_util_unittest.cc: L"0123ABCDwxyz \a\b\t\r\n!+,.~"
--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings
--~--~---------~--~----~------------~-------~--~----~
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/group/chromium-bugs
-~----------~----~----~----~------~----~------~--~---
