Comment #7 on issue 5819 by [email protected]: Browser crash @
Tab::OnMouseReleased
http://code.google.com/p/chromium/issues/detail?id=5819
The following revision refers to this bug:
http://src.chromium.org/viewvc/chrome?view=rev&revision=7615
------------------------------------------------------------------------
r7615 | [email protected] | 2009-01-06 13:29:26 -0800 (Tue, 06 Jan 2009) |
24 lines
Changed paths:
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/tabs/dragged_tab_controller.cc?r1=7615&r2=7614
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/tabs/dragged_tab_controller.h?r1=7615&r2=7614
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/tabs/tab.cc?r1=7615&r2=7614
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/tabs/tab.h?r1=7615&r2=7614
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/tabs/tab_strip.cc?r1=7615&r2=7614
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/tabs/tab_strip.h?r1=7615&r2=7614
Applying patch for Mohamed Mansour (reviewed by pkasting):
http://codereview.chromium.org/16246
CRASH at Tab::OnMouseReleased
Some strange thing is happening that it crashes for view::HitTest, it can
never
ENTER that function. It seems that the tab is being destroyed and as
pkasting
stated on IRC:
"Part of this may be because our retarded Views designs can't distinguish
which
buttons are being held versus clicked in these sorts of cases (I filed a
bug on
this about a year and a half ago, internally)"
When a tab has ended dragging (EndDrag), if something was being dragged and
you
end it, it actually cleans the TabDelegate and assigns its value to 'freed
memory' which is 0xfeeefeee. Therefore it crashes while dragging, because
the
object no longer exists. I couldn't do if (delegate_) cause that always
returns
true since delegate has 0xfeeefeee.
So I just changed the return type from void to bool for underlying
EndDragImpl
and pumped it to tab.cc. That way, we can know if a tab is destroyed or not.
BUG=5819 (http://crbug.com/5819)
TEST=Dragging tabs around, closing while dragging, and closing tabs.
------------------------------------------------------------------------
--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings
--~--~---------~--~----~------------~-------~--~----~
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/group/chromium-bugs
-~----------~----~----~----~------~----~------~--~---
