Comment #4 on issue 3844 by [email protected]: Autofill popup should hide when the page loses focus http://code.google.com/p/chromium/issues/detail?id=3844
The following revision refers to this bug:
http://src.chromium.org/viewvc/chrome?view=rev&revision=7823
------------------------------------------------------------------------
r7823 | [email protected] | 2009-01-09 12:21:11 -0800 (Fri, 09 Jan 2009)
| 9 lines
Changed paths:
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/render_view_host.cc?r1=7823&r2=7822
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/render_view_host.h?r1=7823&r2=7822
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/render_view_host_delegate.h?r1=7823&r2=7822
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/render_widget_helper.cc?r1=7823&r2=7822
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/render_widget_helper.h?r1=7823&r2=7822
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/render_widget_host_view_win.cc?r1=7823&r2=7822
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/render_widget_host_view_win.h?r1=7823&r2=7822
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/resource_message_filter.cc?r1=7823&r2=7822
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/resource_message_filter.h?r1=7823&r2=7822
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/web_contents_view.cc?r1=7823&r2=7822
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/web_contents_view.h?r1=7823&r2=7822
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/web_contents_view_win.cc?r1=7823&r2=7822
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/web_contents_view_win.h?r1=7823&r2=7822
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/render_messages_internal.h?r1=7823&r2=7822
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/mock_render_thread.cc?r1=7823&r2=7822
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/mock_render_thread.h?r1=7823&r2=7822
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/render_view.cc?r1=7823&r2=7822
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/render_view.h?r1=7823&r2=7822
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/render_widget.cc?r1=7823&r2=7822
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/render_widget.h?r1=7823&r2=7822
M
http://src.chromium.org/viewvc/chrome/trunk/src/webkit/glue/chrome_client_impl.cc?r1=7823&r2=7822
M
http://src.chromium.org/viewvc/chrome/trunk/src/webkit/glue/chrome_client_impl.h?r1=7823&r2=7822
M
http://src.chromium.org/viewvc/chrome/trunk/src/webkit/glue/webview_delegate.h?r1=7823&r2=7822
M
http://src.chromium.org/viewvc/chrome/trunk/src/webkit/glue/webview_impl.cc?r1=7823&r2=7822
M
http://src.chromium.org/viewvc/chrome/trunk/src/webkit/tools/test_shell/test_webview_delegate.cc?r1=7823&r2=7822
M
http://src.chromium.org/viewvc/chrome/trunk/src/webkit/tools/test_shell/test_webview_delegate.h?r1=7823&r2=7822
The popup for autofill is now never activated, even when clicked.
This allows us to hide it when the page loses focus.
(doing that previously would have caused the popup to be hidden before the
click in the popup was sent to the renderer).
Most of the file changes are just renaming focus_on_show to activatable.
TEST=Open a form and make an autofill popup. Focus another window, the
popup should disappear. Ensure the autofill still work properly, and the
combo-box as well.
BUG=3844,5830
Review URL: http://codereview.chromium.org/17455
------------------------------------------------------------------------
--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings
--~--~---------~--~----~------------~-------~--~----~
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/group/chromium-bugs
-~----------~----~----~----~------~----~------~--~---
