Comment #2 on issue 6408 by [email protected]: Interstitial crasher
http://code.google.com/p/chromium/issues/detail?id=6408
The following revision refers to this bug:
http://src.chromium.org/viewvc/chrome?view=rev&revision=8350
------------------------------------------------------------------------
r8350 | [email protected] | 2009-01-20 17:08:44 -0800 (Tue, 20 Jan 2009)
| 9 lines
Changed paths:
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/tab_contents/navigation_controller.cc?r1=8350&r2=8349
A crasher would happen if you navigate to a page triggering an interstitial
from the new tab page, then press back in the interstitial.
The crasher would happen because the navigation controller collects
(destroys) the previous tab contents when a navigation is initiated. In
this case, when navigating back (by just discarding the non committed
entries), it would not be expect that the tab contents would be NULL.
It seems we do not need to collect the unused tab contents on
NavigateToPendingEntry() since we are collecting any unused TabContents in
NavigationController::RendererDidNavigate().
BUG=6408
TEST=From the new page, enter the URL to a malware site (ex:
http://ianfette.org), press Back (or close the tab), there should be no
crash.
Review URL: http://codereview.chromium.org/18433
------------------------------------------------------------------------
--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings
--~--~---------~--~----~------------~-------~--~----~
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/group/chromium-bugs
-~----------~----~----~----~------~----~------~--~---
