Comment #42 on issue 5054 by [email protected]: [magic_browzr] Window
frame drawn incorrectly
http://code.google.com/p/chromium/issues/detail?id=5054
The following revision refers to this bug:
http://src.chromium.org/viewvc/chrome?view=rev&revision=8658
------------------------------------------------------------------------
r8658 | [email protected] | 2009-01-26 12:28:25 -0800 (Mon, 26 Jan
2009) | 14 lines
Changed paths:
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/constrained_window_impl.cc?r1=8658&r2=8657
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/frame/opaque_non_client_view.cc?r1=8658&r2=8657
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/frame/opaque_non_client_view.h?r1=8658&r2=8657
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/gfx/chrome_canvas.cc?r1=8658&r2=8657
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/gfx/chrome_canvas.h?r1=8658&r2=8657
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/views/custom_frame_window.cc?r1=8658&r2=8657
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/views/non_client_view.cc?r1=8658&r2=8657
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/views/non_client_view.h?r1=8658&r2=8657
This change should have few user-visible effects. I think I slightly
modified the window layout (by a pixel or so) in the popup window case,
which I haven't tried to make pixel-perfect yet anyway. Otherwise it's all
reorg.
Clean up logic of nonclient view to be more consistent and coherent. Most
things are now based on a small set of core functions that return various
frame/nonclient thicknesses. This allows a noticeable reduction in the
number of hardcoded constants, makes the code make more sense (even though
a few places are longer than before), and makes it much easier to do things
in the future like resizing various borders or handling system metrics
better.
Rename and update comments for all constants to be more descriptive and
less redundant.
Rename helper functions and variables for consistency, now that they've
changed.
Remove an unused variant of TileImageInt(). Add a new one that takes an
offset into the source image. This is used to rewrite the maximized bottom
border tiling call in a way that doesn't rely on someone else clipping out
or painting over the overdraw from tiling "too large" a source image.
Probably no visible effect.
Make resize border hittest helper function able to handle borders of
varying widths, and try to make parameter names more meaningful.
Technically, we don't need the extra flexibility, since our bottom and side
borders are the same thickness, but since there are different functions
calculating that thickness on the caller side, it didn't hurt to not rely
on that for the future.
BUG=5054
Review URL: http://codereview.chromium.org/18804
------------------------------------------------------------------------
--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings
--~--~---------~--~----~------------~-------~--~----~
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/group/chromium-bugs
-~----------~----~----~----~------~----~------~--~---
