Comment #6 on issue 6369 by [email protected]: Chrome: Crash Report -
Stack Signature: -6A4A22C6
http://code.google.com/p/chromium/issues/detail?id=6369
The following revision refers to this bug:
http://src.chromium.org/viewvc/chrome?view=rev&revision=8731
------------------------------------------------------------------------
r8731 | [email protected] | 2009-01-27 10:41:14 -0800 (Tue, 27 Jan 2009) | 27
lines
Changed paths:
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/tabs/dragged_tab_controller.cc?r1=8731&r2=8730
Fixes tab contents crash. This changes a number of things in dragged
tab controller:
. DraggedTabController now installs itself as the delegate of the
TabContents immediately. It needs to do this so that it can stay in
sync if the selected TabContents of the NavigationController
changes.
. DraggedTabController forwards changes to the selected TabContents to
the original delegate. This needs to be done so that the original
delegate can do any cleanup it needs to do. For example, Browser
needs to know if the tab contents changes so that it can remove
entries from its internal mapping of what TabContents need to be
updated. Similarly the TabStripModel needs to install a listener on
the new TabContents type.
. If the tab is destroyed while dragging we shouldn't set the
attached_tabstrip_ to NULL. Doing so results in invoking
source_tabstrip_->DestroyDraggedSourceTab(source_tab_), which is not
what should happen.
These changes are subtle, so give them a good think.
BUG=6369
TEST=this is covered by chrome bot tests. But be sure and exercise tab
dragging in as many permutations as you can to make sure this
doesn't break anything.
Review URL: http://codereview.chromium.org/19026
------------------------------------------------------------------------
--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings
--~--~---------~--~----~------------~-------~--~----~
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/group/chromium-bugs
-~----------~----~----~----~------~----~------~--~---
