Comment #5 on issue 5687 by [email protected]: Port
browser/net/dns_{master,slave} and the unittest for them
http://code.google.com/p/chromium/issues/detail?id=5687
The following revision refers to this bug:
http://src.chromium.org/viewvc/chrome?view=rev&revision=9312
------------------------------------------------------------------------
r9312 | [email protected] | 2009-02-06 04:16:53 -0800 (Fri, 06 Feb
2009) | 11 lines
Changed paths:
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/browser.scons?r1=9312&r2=9311
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/browser.vcproj?r1=9312&r2=9311
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/net/dns_global.cc?r1=9312&r2=9311
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/net/dns_host_info.cc?r1=9312&r2=9311
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/net/dns_host_info.h?r1=9312&r2=9311
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/net/dns_host_info_unittest.cc?r1=9312&r2=9311
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/net/dns_master.cc?r1=9312&r2=9311
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/net/dns_master.h?r1=9312&r2=9311
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/net/dns_master_unittest.cc?r1=9312&r2=9311
D /trunk/src/chrome/browser/net/dns_slave.cc
D /trunk/src/chrome/browser/net/dns_slave.h
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/unit/unit_tests.scons?r1=9312&r2=9311
M
http://src.chromium.org/viewvc/chrome/trunk/src/net/base/host_resolver.h?r1=9312&r2=9311
Clean up dns prefetch code, and also port it.
- remove slave threads and use HostResolver in asynchronous mode instead
(while still limiting number of concurrent lookups)
- make the implementation portable and make DnsMaster unit test compile and
pass on Linux
- add more tests to DnsMaster unit test to simulate various shutdown
scenarios, concurrent lookups, and to verify that we don't exceed our limit
of concurrent lookup requests)
- remove some tests which relied on specifics of slaves' inner working
Bonus: shutdown is almost instant now, no need to have a timeout.
BUG=5687, 6683
Review URL: http://codereview.chromium.org/15076
------------------------------------------------------------------------
--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings
--~--~---------~--~----~------------~-------~--~----~
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/group/chromium-bugs
-~----------~----~----~----~------~----~------~--~---
