Updates:
Status: WontFix
Comment #4 on issue 7215 by [email protected]: RTL: URL should be right
aligned on the "Open the following pages" table
http://code.google.com/p/chromium/issues/detail?id=7215
The fix would be as following:
Index: general_page_view.cc
===================================================================
--- general_page_view.cc (revision 9249)
+++ general_page_view.cc (working copy)
@@ -300,9 +300,12 @@
std::wstring CustomHomePagesTableModel::GetText(int row, int column_id) {
DCHECK(column_id == 0);
DCHECK(row >= 0 && row < RowCount());
- // No need to force URL to have LTR directionality because the custom
home
- // pages control is created using LTR directionality.
- return UTF8ToWide(entries_[row].url.spec());
+ // Force URL to have LTR directionality.
+ std::wstring url = UTF8ToWide(entries_[row].url.spec());
+ if (l10n_util::GetTextDirection() == l10n_util::RIGHT_TO_LEFT) {
+ l10n_util::WrapStringWithLTRFormatting(&url);
+ }
+ return url;
}
SkBitmap CustomHomePagesTableModel::GetIcon(int row) {
@@ -798,8 +801,6 @@
startup_custom_pages_table_ = new views::TableView(
startup_custom_pages_table_model_.get(), columns,
views::ICON_AND_TEXT, true, false, true);
- // URLs are inherently left-to-right, so do not mirror the table.
- startup_custom_pages_table_->EnableUIMirroringForRTLLanguages(false);
startup_custom_pages_table_->SetObserver(this);
using views::GridLayout;
==============================================================================
But changing the URLs to be right-aligned has the following problem:
You only see the rightmost portion of the URL for long URLs (that is, the
http://...
part is on the left and you need to scroll in order to get to it). Idan
remember that
is one reason why we made the URL left-aligned there.
Consulted our Hebrew native speaker and Bidi expert Uri and shoshannah.
They both
think:
"the first screenshot (left-aligned) is much better than the other options.
Since URLs are (almost) always LTR, it makes sense to always left-align
them. I don't
think inconsistency with other elements is an issue here."
Based on which, I mark this bug as "wont fix".
FYI, attach 3 snap shots in this email (2 of them are right-align custom
home page,
and 1 of them is left-align custom home page).
Attachments:
custom_home_page_left_align.png 32.5 KB
custom_home_page_right_align_1.png 30.1 KB
custom_home_page_right_align_2.png 29.8 KB
--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings
--~--~---------~--~----~------------~-------~--~----~
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/group/chromium-bugs
-~----------~----~----~----~------~----~------~--~---
