Comment #1 on issue 7704 by [email protected]: Perf graph colors
should be invariant across graphs
http://code.google.com/p/chromium/issues/detail?id=7704
The following revision refers to this bug:
http://src.chromium.org/viewvc/chrome?view=rev&revision=10124
------------------------------------------------------------------------
r10124 | [email protected] | 2009-02-20 13:05:05 -0800 (Fri, 20 Feb
2009) | 14 lines
Changed paths:
M
http://src.chromium.org/viewvc/chrome/trunk/tools/buildbot/perf/dashboard/ui/generic_plotter.html?r1=10124&r2=10123
Sort traces on the plot so anything with a corresponding _ref trace is
plotted
first. This will help keep the colors consistent. For example, when a graph
has "t", "t_ref", and "gears" plots, a strictly alphabetical sorting puts
the "gears" plot first, when people are used to seeing t and t_ref in the
first
two trace colors.
This is a slightly suboptimal solution. Better would be to incorporate the
"important" marker that process_log.py gets from the test executable. But
that
requires a more substantial reworking, and is deferred to another day.
BUG=7704
TEST=See t and t_ref in blue and yellow on a 3-trace startup plot such as
http://build.chromium.org/buildbot/perf/xp-release-single-core/startup/report.html?history=150
Review URL: http://codereview.chromium.org/20527
------------------------------------------------------------------------
--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings
--~--~---------~--~----~------------~-------~--~----~
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/group/chromium-bugs
-~----------~----~----~----~------~----~------~--~---
