Comment #14 on issue 7701 by [email protected]: Chromium: Crash Report
- Stack Signature: iat_patch::GetIATFunction
http://code.google.com/p/chromium/issues/detail?id=7701
The following revision refers to this bug:
http://src.chromium.org/viewvc/chrome?view=rev&revision=10467
------------------------------------------------------------------------
r10467 | [email protected] | 2009-02-26 07:21:50 -0800 (Thu, 26 Feb 2009)
| 9 lines
Changed paths:
M
http://src.chromium.org/viewvc/chrome/trunk/src/base/iat_patch.cc?r1=10467&r2=10466
M
http://src.chromium.org/viewvc/chrome/trunk/src/base/iat_patch.h?r1=10467&r2=10466
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/autocomplete/autocomplete_edit.cc?r1=10467&r2=10466
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/autocomplete/autocomplete_edit.h?r1=10467&r2=10466
M
http://src.chromium.org/viewvc/chrome/trunk/src/webkit/glue/plugins/webplugin_delegate_impl.cc?r1=10467&r2=10466
M
http://src.chromium.org/viewvc/chrome/trunk/src/webkit/glue/plugins/webplugin_delegate_impl.h?r1=10467&r2=10466
Try a new approach to fixing IAT unpatch crashes when the DLL is gone.
Have the IAT patcher take some "ownership" of the DLL, by taking a library
name and then calling LoadLibrary() / FreeLibrary() to manage the reference
count. This means as long is there isn't some other reference count
balancing bug happening in the process, the DLL will never be unloaded
while we are patched.
This effectively reverts r9929, the VirtualQuery additional checks are
removed.
BUG=7701
Review URL: http://codereview.chromium.org/21453
------------------------------------------------------------------------
--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings
--~--~---------~--~----~------------~-------~--~----~
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/group/chromium-bugs
-~----------~----~----~----~------~----~------~--~---
