Comment #3 on issue 8200 by [email protected]: Throbber in clear
browsing data dialog appears when hitting escape
http://code.google.com/p/chromium/issues/detail?id=8200
The following revision refers to this bug:
http://src.chromium.org/viewvc/chrome?view=rev&revision=10631
------------------------------------------------------------------------
r10631 | [email protected] | 2009-02-27 14:02:15 -0800 (Fri, 27 Feb 2009)
| 18 lines
Changed paths:
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/views/dialog_client_view.cc?r1=10631&r2=10630
Fix 8200: Pressing Esc should cancel dialogs, not commit.
When we create the OK & Cancel dialog buttons in
DialogClientView, we were registering OK as a handler
for Escape, even though the dialog had a Cancel button.
This is because we register for Esc if the member variable
|cancel_ button_| is NULL. Problem is, that member isn't
created until later on in that function.
We should be checking the |buttons| flags instead.
TEST=Open the Clear Browsing Data dialog, press Tab twice,
press Esc and make sure that the dialog closes and nothing
is cleared (from whatever checkbox was selected).
BUG=8200
Review URL: http://codereview.chromium.org/28267
------------------------------------------------------------------------
--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings
--~--~---------~--~----~------------~-------~--~----~
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/group/chromium-bugs
-~----------~----~----~----~------~----~------~--~---
