Updates:
        Status: Started

Comment #4 on issue 5739 by [email protected]: Relaunched browser window  
has size, position of last open popup
http://code.google.com/p/chromium/issues/detail?id=5739

I found the problem. It is because popups started from an app version of  
the browser
are not marked as popups, they are marked as apps... So the protection  
against
persisting the window placement of popups doesn't work (see code below)...  
Would it
be OK to add a new type for POPUP_APP? Or use a bit flag? Or did I miss  
something?

void BrowserView::SaveWindowPlacement(const gfx::Rect& bounds,
                                       bool maximized,
                                       bool always_on_top) {
   // If fullscreen_ is true, we've just changed into fullscreen mode, and  
we're
   // catching the going-into-fullscreen sizing and positioning calls, which  
we
   // want to ignore.
   if (!fullscreen_ && browser_->ShouldSaveWindowPlacement()) {
[...]

bool Browser::ShouldSaveWindowPlacement() const {
   // We don't save window position for popups.
   return type() != TYPE_POPUP;
}

void Browser::BuildPopupWindow(TabContents* source,
                                TabContents* new_contents,
                                const gfx::Rect& initial_pos) {
   Browser* browser =
       new Browser((type_ == TYPE_APP) ? TYPE_APP : TYPE_POPUP, profile_);
[...]



--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings

--~--~---------~--~----~------------~-------~--~----~
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/group/chromium-bugs
-~----------~----~----~----~------~----~------~--~---

Reply via email to