Comment #2 on issue 8154 by [email protected]: File paths in PrefService might be in the wrong encoding on linux http://code.google.com/p/chromium/issues/detail?id=8154
The following revision refers to this bug:
http://src.chromium.org/viewvc/chrome?view=rev&revision=10844
------------------------------------------------------------------------
r10844 | [email protected] | 2009-03-03 16:05:25 -0800 (Tue, 03 Mar 2009)
| 8 lines
Changed paths:
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/browser_main.cc?r1=10844&r2=10843
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/browser_process_impl.cc?r1=10844&r2=10843
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/download/download_manager.cc?r1=10844&r2=10843
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/download/save_package.cc?r1=10844&r2=10843
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/metrics/metrics_service_uitest.cc?r1=10844&r2=10843
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/profile.cc?r1=10844&r2=10843
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/tab_contents/web_contents_unittest.cc?r1=10844&r2=10843
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/chrome_constants.cc?r1=10844&r2=10843
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/chrome_constants.h?r1=10844&r2=10843
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/chrome_paths.cc?r1=10844&r2=10843
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/pref_service.cc?r1=10844&r2=10843
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/pref_service.h?r1=10844&r2=10843
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/pref_service_unittest.cc?r1=10844&r2=10843
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/data/pref_service/read.json?r1=10844&r2=10843
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/data/pref_service/write.golden.json?r1=10844&r2=10843
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/reliability/page_load_test.cc?r1=10844&r2=10843
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/testing_profile.h?r1=10844&r2=10843
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/unit/unit_tests.scons?r1=10844&r2=10843
Add FilePath setter/getter to pref service. Change callers to use it rather
than the string methods.
Update the pref service unit test and enable it on linux.
Also switch over some wstrings to filepaths where appropriate.
BUG=8154
Review URL: http://codereview.chromium.org/27354
------------------------------------------------------------------------
--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings
--~--~---------~--~----~------------~-------~--~----~
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/group/chromium-bugs
-~----------~----~----~----~------~----~------~--~---
