Comment #3 on issue 7673 by [email protected]: Sad face not displayed
after a plugin crash
http://code.google.com/p/chromium/issues/detail?id=7673
The following revision refers to this bug:
http://src.chromium.org/viewvc/chrome?view=rev&revision=10960
------------------------------------------------------------------------
r10960 | [email protected] | 2009-03-04 18:07:18 -0800 (Wed, 04 Mar 2009)
| 10 lines
Changed paths:
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/plugin_process_host.cc?r1=10960&r2=10959
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/plugin_process_host.h?r1=10960&r2=10959
Ensure that we display a sad face for a windowed plugin when the plugin
process crashes. This was a regression introduced by creating the plugin
parent on the browser UI thread, which remains valid when the plugin
process crashes.
The fix is to track plugin wrapper windows in the PluginProcessHost class
and destroy any remaining windows in the destructor. Removed the
DestroyWindowTask
which destroys the windows on the UI thread. We can achieve the same result
by posting WM_CLOSE messages to these windows.
This fixes http://code.google.com/p/chromium/issues/detail?id=7673
Bug=7673
Review URL: http://codereview.chromium.org/40120
------------------------------------------------------------------------
--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings
--~--~---------~--~----~------------~-------~--~----~
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/group/chromium-bugs
-~----------~----~----~----~------~----~------~--~---
