Comment #3 on issue 8236 by [email protected]: Implement location bar
and omnibox on GTK.
http://code.google.com/p/chromium/issues/detail?id=8236
The following revision refers to this bug:
http://src.chromium.org/viewvc/chrome?view=rev&revision=11527
------------------------------------------------------------------------
r11527 | [email protected] | 2009-03-12 04:15:14 -0700 (Thu, 12 Mar 2009)
| 30 lines
Changed paths:
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_gtk.cc?r1=11527&r2=11526
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_gtk.h?r1=11527&r2=11526
Better keyboard and mouse handling in Omnibox:
- Grab enter key events before they get to GtkTextView.
We need to do this, otherwise enter when text is selected
will replace the text, and we won't get a chance to catch
that happening. This might have problems with IME, but it
should be straightforward to fix anything IME related.
- Don't deselect when we lose focus. This sometimes looks a
bit strange, but it's the GTK thing to do. This also unbreaks
copy and paste via the context menu, since popping up the
context menu makes the GtkTextView lose focus.
- Rewrite the inefficent newline eater. This should now only be
needed for newlines that didn't come from the keyboard (like when
you paste text). Use the builtin iter support for finding line
boundaries, hopefully more efficient than checking the characters
one by one. Still might have some bad behavior when pasting a ton
of newline characters, but that can be improved later.
This fixes inline autocomplete, you can now hit the enter key on an
inline autocompleted suggestion, and you will get the intented navigation,
instead of the navigation with the selected completion removed.
This also adds support for alt-enter in Omnibox to navigate in a new tab.
BUG=8236
Review URL: http://codereview.chromium.org/43072
------------------------------------------------------------------------
--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings
--~--~---------~--~----~------------~-------~--~----~
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/group/chromium-bugs
-~----------~----~----~----~------~----~------~--~---
