Comment #2 on issue 8684 by [email protected]: RTL Regression: Text
should be right aligned for RTL languages on "Bookmark Manager"
http://code.google.com/p/chromium/issues/detail?id=8684
The following revision refers to this bug:
http://src.chromium.org/viewvc/chrome?view=rev&revision=11639
------------------------------------------------------------------------
r11639 | [email protected] | 2009-03-13 10:00:38 -0700 (Fri, 13 Mar 2009) |
23 lines
Changed paths:
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/bookmark_table_view.cc?r1=11639&r2=11638
This CL fixes issue 8684 -- RTL Regression: Text should be right aligned
for RTL languages on "Bookmark Manager"
(http://crbug.com/8684)
The problem is canvas.DrawStringWithHalo() within
BookmarkTableView::PaintAltText() always use left alignment.
The fix is to pass the correct canvas text alignment when
DrawStringWithHalo().
Test:
1. Run Hebrew Chrome
2. Hit Ctrl + Shift + B go to "Bookmark Manager" dialog
3. Select "Search"
4. Observe
Without the fix:
Text "Enter a query in the text field above to search your bookmarks" is
left aligned
With the fix:
The above text is right aligned Hebrew
Review URL: http://codereview.chromium.org/43146
------------------------------------------------------------------------
--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings
--~--~---------~--~----~------------~-------~--~----~
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/group/chromium-bugs
-~----------~----~----~----~------~----~------~--~---
