Comment #13 on issue 8627 by [email protected]: REGRESSION: igoogle:
autofill opens unwanted
http://code.google.com/p/chromium/issues/detail?id=8627
The following revision refers to this bug:
http://src.chromium.org/viewvc/chrome?view=rev&revision=12367
------------------------------------------------------------------------
r12367 | [email protected] | 2009-03-24 10:56:58 -0700 (Tue, 24 Mar
2009) | 6 lines
Changed paths:
M
http://src.chromium.org/viewvc/chrome/trunk/src/webkit/glue/dom_operations.cc?r1=12367&r2=12366
M
http://src.chromium.org/viewvc/chrome/trunk/src/webkit/glue/dom_operations.h?r1=12367&r2=12366
M
http://src.chromium.org/viewvc/chrome/trunk/src/webkit/glue/editor_client_impl.cc?r1=12367&r2=12366
M
http://src.chromium.org/viewvc/chrome/trunk/src/webkit/glue/webview_impl.cc?r1=12367&r2=12366
Clicking a text field that is already focused triggers the autofill.
However the code triggering this was just checking that the focused element
before and after processing the event was the same.
We need to do a hit test to ensure the click is really on the text field,
otherwise in cases where clicking somewhere in the page does not change the
focus, we would bogusly bring up the autofill popup.
BUG=8627
TEST=Ensure autocomplete popup still works as expected: when entering
text, when using up/down arrows, when clicking selected text field. Also
ensures the scenario from the bug does not trigger the popup.
Review URL: http://codereview.chromium.org/50038
------------------------------------------------------------------------
--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings
--~--~---------~--~----~------------~-------~--~----~
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/group/chromium-bugs
-~----------~----~----~----~------~----~------~--~---
