Comment #8 on issue 8170 by [email protected]: Crash on tar.gz
extension
http://code.google.com/p/chromium/issues/detail?id=8170
The following revision refers to this bug:
http://src.chromium.org/viewvc/chrome?view=rev&revision=12410
------------------------------------------------------------------------
r12410 | [email protected] | 2009-03-24 16:38:01 -0700 (Tue, 24 Mar
2009) | 8 lines
Changed paths:
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/renderer_host/download_throttling_resource_handler.cc?r1=12410&r2=12409
Prevent data read errors from crashing the browser.
In ResourceDispatcherHost::OnResponseStarted(), if Read() causes an error,
it calls OnResponseCompleted(). For a download, this hits the NOTREACHED()
in DownloadThrottlingResourceHandler::OnResponseCompleted().
This patch checks for the error status, and returns false, which causes the
download to finish, which saves an empty file of size 0.
BUG=8170
Review URL: http://codereview.chromium.org/42573
------------------------------------------------------------------------
--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings
--~--~---------~--~----~------------~-------~--~----~
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/group/chromium-bugs
-~----------~----~----~----~------~----~------~--~---
