Comment #5 on issue 8963 by [email protected]: REGRESSION: bookmarks
UI disappears when starting a navigation from the NTP
http://code.google.com/p/chromium/issues/detail?id=8963
The following revision refers to this bug:
http://src.chromium.org/viewvc/chrome?view=rev&revision=12515
------------------------------------------------------------------------
r12515 | [email protected] | 2009-03-25 16:12:16 -0700 (Wed, 25 Mar 2009)
| 15 lines
Changed paths:
A
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/dom_ui/dom_ui_unittest.cc
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/dom_ui/new_tab_ui.cc?r1=12515&r2=12514
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/dom_ui/new_tab_ui.h?r1=12515&r2=12514
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/tab_contents/render_view_host_manager.cc?r1=12515&r2=12514
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/tab_contents/render_view_host_manager.h?r1=12515&r2=12514
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/tab_contents/web_contents.cc?r1=12515&r2=12514
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/tab_contents/web_contents.h?r1=12515&r2=12514
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/chrome.gyp?r1=12515&r2=12514
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/unit/unittests.vcproj?r1=12515&r2=12514
Make the bookmarks bar disappear when the load after the new tab page
commits
rather than when it is pending. This makes it change at the same time the
page changes.
To support this, we now have to keep track of both a pending and a committed
DOMUI object. This is tracked by the RenderManager, which does a similar
swapping between pending and committed RenderViewHosts.
Previous review URL: http://codereview.chromium.org/42512
The only difference is I swapped the order of creating the DOM UI in
RenderViewHostManager::Navigate.
BUG=8963
Review URL: http://codereview.chromium.org/42623
------------------------------------------------------------------------
--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings
--~--~---------~--~----~------------~-------~--~----~
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/group/chromium-bugs
-~----------~----~----~----~------~----~------~--~---
