Comment #1 on issue 7967 by [email protected]: editing resources
causes lots of stuff to compile
http://code.google.com/p/chromium/issues/detail?id=7967
The following revision refers to this bug:
http://src.chromium.org/viewvc/chrome?view=rev&revision=12630
------------------------------------------------------------------------
r12630 | [email protected] | 2009-03-26 18:01:45 -0700 (Thu, 26 Mar 2009) | 11
lines
Changed paths:
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/chrome_resources.vcproj?r1=12630&r2=12629
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/chrome_strings.vcproj?r1=12630&r2=12629
M
http://src.chromium.org/viewvc/chrome/trunk/src/tools/grit/build/grit_resources.rules?r1=12630&r2=12629
M
http://src.chromium.org/viewvc/chrome/trunk/src/tools/grit/grit/format/rc_header.py?r1=12630&r2=12629
M
http://src.chromium.org/viewvc/chrome/trunk/src/tools/grit/grit/tool/build.py?r1=12630&r2=12629
This fixes a few GRIT issues:
- The generated header files had the wrong paths specified in the vcproj
files.
- Have the .h files generate to a temp file and overwrite the real .h files
if they changed from the last run. This prevents recompiling when only a
resource is changed.
- Change the output file to the .rc file because otherwise the vcproj file
would recompile every time because the .h file wasn't changing. Since
the .rc file gets written all the time, this isn't a problem.
On a side note, you still have to re-link to get the resources in
chrome.dll. I imagine if you turn on incremental linking, this would be
pretty fast.
BUG=7967
Review URL: http://codereview.chromium.org/53028
------------------------------------------------------------------------
--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings
--~--~---------~--~----~------------~-------~--~----~
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/group/chromium-bugs
-~----------~----~----~----~------~----~------~--~---
