Comment #3 on issue 9109 by [email protected]: From DnsMasterTest suite, only OsCachesLookupsTest should be making real DNS queries http://code.google.com/p/chromium/issues/detail?id=9109
The following revision refers to this bug:
http://src.chromium.org/viewvc/chrome?view=rev&revision=12653
------------------------------------------------------------------------
r12653 | [email protected] | 2009-03-27 09:22:26 -0700 (Fri, 27 Mar
2009) | 13 lines
Changed paths:
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_view_unittest.cc?r1=12653&r2=12652
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/net/dns_master_unittest.cc?r1=12653&r2=12652
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/find_bar_win_unittest.cc?r1=12653&r2=12652
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/unit/chrome_test_suite.h?r1=12653&r2=12652
M
http://src.chromium.org/viewvc/chrome/trunk/src/net/base/host_resolver.cc?r1=12653&r2=12652
M
http://src.chromium.org/viewvc/chrome/trunk/src/net/base/host_resolver.h?r1=12653&r2=12652
M
http://src.chromium.org/viewvc/chrome/trunk/src/net/base/host_resolver_unittest.h?r1=12653&r2=12652
M
http://src.chromium.org/viewvc/chrome/trunk/src/net/base/ssl_client_socket_unittest.cc?r1=12653&r2=12652
M
http://src.chromium.org/viewvc/chrome/trunk/src/net/http/http_network_layer_unittest.cc?r1=12653&r2=12652
Prevent making real DNS lookups by chrome tests.
- by default a test which makes external DNS lookup directly or indirectly
will fail
- added a quite simple way to allow a test to make external queries
- added a way to make external queries fail (for tests which don't need
them to succeed but it's hard to not make the query)
- made neccessary adjustments to existing tests so that they still pass
http://crbug.com/9109
Review URL: http://codereview.chromium.org/45026
------------------------------------------------------------------------
--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings
--~--~---------~--~----~------------~-------~--~----~
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/group/chromium-bugs
-~----------~----~----~----~------~----~------~--~---
