Updates:
Summary: Browser crash @ std::_Tree<std::_Tmap_traits<unsigned
int,ObserverList<NotificationObserver,0>
Comment #5 on issue 9286 by [email protected]: Browser crash @
std::_Tree<std::_Tmap_traits<unsigned
int,ObserverList<NotificationObserver,0>
http://code.google.com/p/chromium/issues/detail?id=9286
The following revision refers to this bug:
http://src.chromium.org/viewvc/chrome?view=rev&revision=12727
------------------------------------------------------------------------
r12727 | [email protected] | 2009-03-27 16:29:45 -0700 (Fri, 27 Mar
2009) | 14 lines
Changed paths:
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/tab_contents/interstitial_page.cc?r1=12727&r2=12726
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/tab_contents/interstitial_page.h?r1=12727&r2=12726
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/tab_contents/web_contents_unittest.cc?r1=12727&r2=12726
The URL in the bug triggers an SSL interstitial for a redirect that
redirects to a bad SSL page.
This happens because:
- when proceeding on an interstitial, we wait for the navigation to commit
before hiding the current interstitial
- when showing an interstitial, if an interstitial is already showing we
call DontProceed on it
In the case of this bug, the interstitial has already been approved when
the showing of the 2nd interstitial calls DontProceed on it, causing bad
things to happen.
The fix is easy: we shouldn't call DontProceed on an interstitial
already "Proceeded".
BUG=9286
TEST=See bug.
Review URL: http://codereview.chromium.org/56019
------------------------------------------------------------------------
--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings
--~--~---------~--~----~------------~-------~--~----~
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/group/chromium-bugs
-~----------~----~----~----~------~----~------~--~---
