Comment #2 on issue 8584 by [email protected]: Regression: "Install
plug-in" infor bar doesn't show up
http://code.google.com/p/chromium/issues/detail?id=8584
The following revision refers to this bug:
http://src.chromium.org/viewvc/chrome?view=rev&revision=12733
------------------------------------------------------------------------
r12733 | [email protected] | 2009-03-27 19:41:56 -0700 (Fri, 27 Mar 2009)
| 18 lines
Changed paths:
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/chrome.sln?r1=12733&r2=12732
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/plugin/plugin_test.cpp?r1=12733&r2=12732
M
http://src.chromium.org/viewvc/chrome/trunk/src/webkit/default_plugin/plugin_impl_win.cc?r1=12733&r2=12732
M
http://src.chromium.org/viewvc/chrome/trunk/src/webkit/default_plugin/plugin_impl_win.h?r1=12733&r2=12732
It looks like the Chrome NPAPI plugin installer has been broken since we
first updated chrome webkit after 1.0 shipped.
Basically in the 1.0 branch when the plugin was instantiated in its
instantiation it would get the mime type along with the list of other
arguments. If an object tag was specified with the classid, it would get
mapped to the mime type. With the webkit merge the classs id is passed in
along with the mime type.
The plugin installer thinks that this is an activex installation on
receiving a valid class id and
and ends up checking if it is a white listed classid, etc.
All this code will be taken out along with the activex shim in the near
future. For now we take this code path only if we don't have a valid mime
type.
This fixes http://code.google.com/p/chromium/issues/detail?id=8584
Added a plugin test for the argument parsing functionality in the default
plugin. I changed the ParseInstantiationArguments function in the
plugin installer to a static function to be able to unit test this.
Bug=8584
Review URL: http://codereview.chromium.org/42684
------------------------------------------------------------------------
--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings
--~--~---------~--~----~------------~-------~--~----~
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/group/chromium-bugs
-~----------~----~----~----~------~----~------~--~---
