Status: Untriaged
Owner: ----
Labels: Type-Bug Pri-2 OS-All Area-Misc Size-Medium valgrind

New issue 9553 by [email protected]: Uninitialized memory reference in  
PlatformContextSkia::currentPathInLocalCoordinates()
http://code.google.com/p/chromium/issues/detail?id=9553

Tests
LayoutTests/svg/dynamic-updates/SVGMarkerElement-dom-markerHeight-attr.html
LayoutTests/svg/dynamic-updates/SVGMarkerElement-dom-markerWidth-attr.html
LayoutTests/svg/dynamic-updates/SVGMarkerElement-svgdom-markerHeight-prop.html
LayoutTests/svg/dynamic-updates/SVGMarkerElement-svgdom-markerWidth-prop.html
show valgrind errors like this:

18:47:01 valgrind_analyze.py [ERROR] UninitCondition
Conditional jump or move depends on uninitialised value(s)
   SkMatrix::getType() const (skia/include/corecg/SkMatrix.h:48)
   SkPath::transform(SkMatrix const&, SkPath*) const  
(skia/sgl/SkPath.cpp:849)
   SkPath::transform(SkMatrix const&) (skia/include/SkPath.h:454)
   PlatformContextSkia::currentPathInLocalCoordinates() const
(third_party/WebKit/WebCore/platform/graphics/skia/PlatformContextSkia.cpp:470)
   WebCore::GraphicsContext::fillPath()
(third_party/WebKit/WebCore/platform/graphics/skia/GraphicsContextSkia.cpp:687)
   WebCore::SVGPaintServer::renderPath(WebCore::GraphicsContext*&,
WebCore::RenderObject const*, WebCore::SVGPaintTargetType) const
(third_party/WebKit/WebCore/svg/graphics/SVGPaintServer.cpp:180)
   WebCore::SVGPaintServer::draw(WebCore::GraphicsContext*&,  
WebCore::RenderObject
const*, WebCore::SVGPaintTargetType) const
(third_party/WebKit/WebCore/svg/graphics/SVGPaintServer.cpp:171)
   WebCore::fillAndStrokePath(WebCore::Path const&,  
WebCore::GraphicsContext*,
WebCore::RenderStyle*, WebCore::RenderPath*)
(third_party/WebKit/WebCore/rendering/RenderPath.cpp:211)
   WebCore::RenderPath::paint(WebCore::RenderObject::PaintInfo&, int, int)
(third_party/WebKit/WebCore/rendering/RenderPath.cpp:238)
   WebCore::RenderSVGContainer::paint(WebCore::RenderObject::PaintInfo&,  
int, int)
(third_party/WebKit/WebCore/rendering/RenderSVGContainer.cpp:199)

Uninitialised value was created by a stack allocation
   PlatformContextSkia::currentPathInLocalCoordinates() const
(third_party/WebKit/WebCore/platform/graphics/skia/PlatformContextSkia.cpp:464)

So it seems to think that inverseMatrix has some uninitialized bits in this  
code:

464 SkPath PlatformContextSkia::currentPathInLocalCoordinates() const
465 {
466     SkPath localPath = m_path;
467     const SkMatrix& matrix = m_canvas->getTotalMatrix();
468     SkMatrix inverseMatrix;
469     matrix.invert(&inverseMatrix);
470     localPath.transform(inverseMatrix);

Perhaps the return value of matrix.invert() needs to be checked.

--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings

--~--~---------~--~----~------------~-------~--~----~
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/group/chromium-bugs
-~----------~----~----~----~------~----~------~--~---

Reply via email to