Comment #2 on issue 9795 by [email protected]: Find-In page resets the  
search to begining of the page always..
http://code.google.com/p/chromium/issues/detail?id=9795

The following revision refers to this bug:
     http://src.chromium.org/viewvc/chrome?view=rev&revision=13510

------------------------------------------------------------------------
r13510 | [email protected] | 2009-04-10 09:38:19 -0700 (Fri, 10 Apr 2009)  
| 30 lines
Changed paths:
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/webkit/glue/webframe_impl.cc?r1=13510&r2=13509
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/webkit/glue/webframe_impl.h?r1=13510&r2=13509

Let WebKit draw the active highlight for FindInPage,
instead of using the SelectionController.

This fixes a couple of bugs, such as:

Active match highlighting disappears when mouse selection
is made within the page and selection color is orange (6145).

and

Selection color becomes orange in some cases on tabs that
don't have a Find box open.

and

Gmail jumping to the first match if on FindNext if Find box
is closed and reopened (9795).

NOTE: This patch depends on my patch to WebKit that just
got accepted. See:
https://bugs.webkit.org/show_bug.cgi?id=25102

BUG=6145, 9795
TEST=Find something on a page that results in multiple
matches being found. Highlight another word that is not
currently highlighted. You should see both active and
inactive highlights (orange and yellow) and a blue colored
selection highlight.

Review URL: http://codereview.chromium.org/66016
------------------------------------------------------------------------


--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings

--~--~---------~--~----~------------~-------~--~----~
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/group/chromium-bugs
-~----------~----~----~----~------~----~------~--~---

Reply via email to