Comment #2 on issue 9959 by [email protected]: Chrome: Crash Report -
Stack Signature: views::View::PropagateRemoveNotifications - (closing
Chrome when D/L in progress)
http://code.google.com/p/chromium/issues/detail?id=9959
The following revision refers to this bug:
http://src.chromium.org/viewvc/chrome?view=rev&revision=13515
------------------------------------------------------------------------
r13515 | [email protected] | 2009-04-10 09:57:58 -0700 (Fri, 10 Apr
2009) | 8 lines
Changed paths:
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/frame/browser_view.cc?r1=13515&r2=13514
The dialog delegate for the in-progress download warning was deleted twice.
It is the content view for the dialog and as such is automatically deleted
when the dialog is closed.
So it does not need to delete itself on the DeleteDelegate() callback.
We were also leaking the label_.
BUG=9959
TEST=Start a big download, close the browser while the download is in
progress. A dialog pops-up. Try the close button. The browser should close
(and not crash!). Try again but this time with "Wait for donwloads to
finish".
Review URL: http://codereview.chromium.org/66038
------------------------------------------------------------------------
--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings
--~--~---------~--~----~------------~-------~--~----~
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/group/chromium-bugs
-~----------~----~----~----~------~----~------~--~---
