Comment #31 on issue 9762 by [email protected]: Regression:
Shift+Ctrl+Arrow selection combination also changes text direction in RTL
UIs
http://code.google.com/p/chromium/issues/detail?id=9762
The following revision refers to this bug:
http://src.chromium.org/viewvc/chrome?view=rev&revision=13588
------------------------------------------------------------------------
r13588 | [email protected] | 2009-04-12 21:56:20 -0700 (Sun, 12 Apr 2009)
| 15 lines
Changed paths:
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/renderer_host/render_widget_host.cc?r1=13588&r2=13587
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/renderer_host/render_widget_host.h?r1=13588&r2=13587
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/renderer_host/render_widget_host_view_win.cc?r1=13588&r2=13587
A quick fix for Issue 9762 and 9763.
This is caused by my change r12434 that does not check if there are any
other keys pressed when a user presses left-control and left-shift keys (or
right-control and right-shift keys).
To fix this issue, this change does not only add the above check, but also
it adds code that cancels updating the text direction if a user presses
another key while he/she is pressing control and shift keys.
BUG=9762 "Regression: Shift+Ctrl+Arrow selection combination also changes
text direction in RTL UIs"
BUG=9763 "Ctrl+Shift text alignment depends of the sides of both the Ctrl
and the Shift keys"
TEST=In a LTR <textarea> element, pressing a control key, pressing a
right-shift key, releasing the right-shift key, and verify its text
direction is changed to RTL.
TEST=In an RTL <textarea> element, pressing a control key, pressing a
left-shift key, releasing the left-shift key, and verify its text direction
is changed to LTR.
TEST=In a LTR <textarea> element, pressing a right-shift key, pressing a
control key, releasing the right-shift key, and verify its text direction
is still LTR.
TEST=In a LTR <textarea> element, pressing a control key, pressing a
right-shift key, releasing the control key, and verify its text direction
is changed to RTL.
TEST=In an RTL <textarea> element, pressing a left-shift key, pressing a
control key, releasing the left-shift key, and verify its text direction is
still RTL.
TEST=In an RTL <textarea> element, pressing a control key, pressing a
left-shift key, releasing the control key, and verify its text direction is
changed to LTR.
TEST=In a LTR <textarea> element, pressing a control key, pressing a
right-shift key, pressing an arrow key, releasing the right-shift key, and
verify its text direction is still LTR.
Review URL: http://codereview.chromium.org/63117
------------------------------------------------------------------------
--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings
--~--~---------~--~----~------------~-------~--~----~
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/group/chromium-bugs
-~----------~----~----~----~------~----~------~--~---
