Comment #5 on issue 8584 by [email protected]: Regression: "Install
plug-in" infor bar doesn't show up
http://code.google.com/p/chromium/issues/detail?id=8584
The following revision refers to this bug:
http://src.chromium.org/viewvc/chrome?view=rev&revision=13610
------------------------------------------------------------------------
r13610 | [email protected] | 2009-04-13 11:47:31 -0700 (Mon, 13 Apr 2009)
| 35 lines
Changed paths:
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/chrome.sln?r1=13610&r2=13609
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/plugin/plugin_test.cpp?r1=13610&r2=13609
M
http://src.chromium.org/viewvc/chrome/trunk/src/webkit/activex_shim/activex_shared.cc?r1=13610&r2=13609
M
http://src.chromium.org/viewvc/chrome/trunk/src/webkit/activex_shim/activex_shared.h?r1=13610&r2=13609
M
http://src.chromium.org/viewvc/chrome/trunk/src/webkit/default_plugin/plugin_main.cc?r1=13610&r2=13609
M
http://src.chromium.org/viewvc/chrome/trunk/src/webkit/glue/plugins/plugin_list_win.cc?r1=13610&r2=13609
M
http://src.chromium.org/viewvc/chrome/trunk/src/webkit/glue/webframeloaderclient_impl.cc?r1=13610&r2=13609
M
http://src.chromium.org/viewvc/chrome/trunk/src/webkit/tools/test_shell/plugin_tests.cc?r1=13610&r2=13609
M
http://src.chromium.org/viewvc/chrome/trunk/src/webkit/tools/test_shell/test_shell.cc?r1=13610&r2=13609
Relanding the following revisions.
r13555
Log:
Remove the Activex shim registration for generic Activex controls. The
Activex shim only handles windows media
player in the wild and will continue to do so for the forseeable future.
This fixes http://code.google.com/p/chromium/issues/detail?id=8584, which
is basically related to our NPAPI plugin
installer not getting instantiated on pages which instantiated flash using
an object tag, which would result in
webkit attempting to instantiate the activex shim. The shim only loads the
windows media player classid, thus causing
this issue.
Added a test shell test which tests whether the default plugin loaded
correctly. This is done by attempting to instantiate
a special mime type application/chromium-test-default-plugin, which serves
as an indicator to the default plugin to
call a function in the page indicating that the test succeeded. I also made
a change to ensure that the default plugin
is loaded in test_shell_tests.
Removed the activexshim dll project from chrome.sln
Bug=8584
New Revision: 13558
Log:
Removing the Activex shim plugin from the list of default plugins caused
some activex shim tests to fail. This basically
fails for pages which instantiate the media player like an activex only. To
handle this case we attempt to map the clsid
to a NPAPI mime type if possible in the shim. If we succeed then the shim
is instantiated as an NPAPI plugin as before.
It internally loads the media player activex.
The other changes are to ensure that the default plugin is only enabled in
test_shell for windows for now.
Bug=8584
Review URL: http://codereview.chromium.org/72004
------------------------------------------------------------------------
--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings
--~--~---------~--~----~------------~-------~--~----~
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/group/chromium-bugs
-~----------~----~----~----~------~----~------~--~---
