Status: Assigned Owner: [email protected] Labels: Type-Bug Pri-2 OS-Linux Area-Misc Size-Medium
New issue 10560 by [email protected]: [linux] [valgrind] We're leaking our TabGtk object http://code.google.com/p/chromium/issues/detail?id=10560 From valgrind: ==10312== 1,572 (352 direct, 1,220 indirect) bytes in 2 blocks are definitely lost in loss record 158 of 241 ==10312== at 0x7BCA04C: operator new(unsigned int) /tmp/vg/coregrind/m_replacemalloc/vg_replace_malloc.c:211 ==10312== by 0x82AC33E: TabStripGtk::TabInsertedAt(TabContents*, int, bool) /src/chrome/src/chrome/browser/gtk/tabs/tab_strip_gtk.cc:651 ==10312== by 0x81FA5C4: TabStripModel::InsertTabContentsAt(int, TabContents*, bool, bool) /src/chrome/src/chrome/browser/tabs/tab_strip_model.cc:104 ==10312== by 0x81FAB40: TabStripModel::AddTabContents(TabContents*, int, unsigned int, bool) /src/chrome/src/chrome/browser/tabs/tab_strip_model.cc:366 ==10312== by 0x824DA5B: Browser::AddTabWithURL(GURL const&, GURL const&, unsigned int, bool, int, SiteInstance*) /src/chrome/src/chrome/browser/browser.cc:525 ==10312== by 0x824DB84: Browser::AddBlankTabAt(int, bool) /src/chrome/src/chrome/browser/browser.cc:1359 ==10312== by 0x82466F1: Browser::AddBlankTab(bool) /src/chrome/src/chrome/browser/browser.cc:1354 ==10312== by 0x824D8C6: Browser::NewTab() /src/chrome/src/chrome/browser/browser.cc:721 ==10312== by 0x824EE74: Browser::ExecuteCommandWithDisposition(int, WindowOpenDisposition) /src/chrome/src/chrome/browser/browser.cc:1210 ==10312== by 0x824F0DF: Browser::ExecuteCommand(int) /src/chrome/src/chrome/browser/browser.cc:1347 ==10312== by 0x835B16C: BrowserToolbarGtk::ExecuteCommand(int) /src/chrome/src/chrome/browser/gtk/browser_toolbar_gtk.cc:196 ==10312== by 0x836174F: MenuGtk::OnMenuItemActivated(_GtkMenuItem*, MenuGtk*) /src/chrome/src/chrome/browser/gtk/menu_gtk.cc:224 It looks like the |TabGtk* tab| in TabData never gets deleted. I don't think we can use a scoped ptr because there's no copying of scoped ptrs. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~---------~--~----~------------~-------~--~----~ Automated mail from issue updates at http://crbug.com/ Subscription options: http://groups.google.com/group/chromium-bugs -~----------~----~----~----~------~----~------~--~---
