Comment #10 on issue 9324 by [email protected]: run_webkit_tests
should implement per test timeout
http://code.google.com/p/chromium/issues/detail?id=9324
The following revision refers to this bug:
http://src.chromium.org/viewvc/chrome?view=rev&revision=13867
------------------------------------------------------------------------
r13867 | [email protected] | 2009-04-16 12:36:32 -0700 (Thu, 16 Apr 2009) |
11 lines
Changed paths:
M
http://src.chromium.org/viewvc/chrome/trunk/src/webkit/tools/layout_tests/layout_package/test_expectations.py?r1=13867&r2=13866
M
http://src.chromium.org/viewvc/chrome/trunk/src/webkit/tools/layout_tests/layout_package/test_shell_thread.py?r1=13867&r2=13866
M
http://src.chromium.org/viewvc/chrome/trunk/src/webkit/tools/layout_tests/run_webkit_tests.py?r1=13867&r2=13866
M
http://src.chromium.org/viewvc/chrome/trunk/src/webkit/tools/layout_tests/test_expectations.txt?r1=13867&r2=13866
M
http://src.chromium.org/viewvc/chrome/trunk/src/webkit/tools/test_shell/test_shell_main.cc?r1=13867&r2=13866
Add concept of slow tests. Only mark one test as slow for now. After
checkin, I'll add a ton of slow tests and reduce the timeout for non-slow
tests to something like 1 second.
To aid in that, I've added 90th percentile and 99th percentile times to the
statistics we report. Also made it so that tests marked as slow and
timeout/crash tests are listed separately from the slowest 50 tests so that
list can be used to know which tests to mark slow.
Tests cannot be marked as both SLOW and TIMEOUT. If the test times out,
then we want it to timeout early to avoid waiting a long timeout for a test
that we know is just going to timeout.
TestShell can now do per-test timeouts. We could easily make
run-webkit-tests do per-test timeouts, but I think just having the one
modifier of SLOW is easier to grok. Makes the test lists simpler and allows
for having longer timeouts on debug/purify builders.
BUG=9324
Review URL: http://codereview.chromium.org/67198
------------------------------------------------------------------------
--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings
--~--~---------~--~----~------------~-------~--~----~
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/group/chromium-bugs
-~----------~----~----~----~------~----~------~--~---
