Comment #1 on issue 10573 by [email protected]: Dismissing Find-in
page no more highlights the last occurance.
http://code.google.com/p/chromium/issues/detail?id=10573
The following revision refers to this bug:
http://src.chromium.org/viewvc/chrome?view=rev&revision=13945
------------------------------------------------------------------------
r13945 | [email protected] | 2009-04-17 10:00:12 -0700 (Fri, 17 Apr 2009)
| 21 lines
Changed paths:
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/browser_focus_uitest.cc?r1=13945&r2=13944
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/find_bar_win_unittest.cc?r1=13945&r2=13944
A
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/data/find_in_page/end_state.html
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/ui_test_utils.cc?r1=13945&r2=13944
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/ui_test_utils.h?r1=13945&r2=13944
M
http://src.chromium.org/viewvc/chrome/trunk/src/webkit/glue/webframe_impl.cc?r1=13945&r2=13944
Fix 10573: Dismissing Find-in page doesn't set focus
to the link found.
We no longer use the selection controller to
highlight the active match. Before this change,
the focus would not be set if the user had changed
the selection. After this change, the focus will
be set unless the user has selected something on
the page.
I also wrote an in-browser unit test for this to
catch this regression in the future, but it is
disabled due to problem with running multiple
in-process browser tests in a row (teardown
problem).
BUG=10573
TEST=Covered by in process browser test now, see
bug for repro steps.
Review URL: http://codereview.chromium.org/79024
------------------------------------------------------------------------
--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings
--~--~---------~--~----~------------~-------~--~----~
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/group/chromium-bugs
-~----------~----~----~----~------~----~------~--~---
