Comment #30 on issue 11226 by [email protected]: Dead keys and accents  
input not working
http://code.google.com/p/chromium/issues/detail?id=11226

The following revision refers to this bug:
     http://src.chromium.org/viewvc/chrome?view=rev&revision=19009

------------------------------------------------------------------------
r19009 | [email protected] | 2009-06-22 22:35:02 -0700 (Mon, 22 Jun 2009)  
| 9 lines
Changed paths:
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/renderer_host/render_widget_host.cc?r1=19009&r2=19008
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/renderer_host/render_widget_host.h?r1=19009&r2=19008
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/renderer_host/render_widget_host_view_gtk.cc?r1=19009&r2=19008
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/renderer_host/render_widget_host_view_gtk.h?r1=19009&r2=19008
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/native_web_keyboard_event.h?r1=19009&r2=19008
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/native_web_keyboard_event_linux.cc?r1=19009&r2=19008
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/webkit/api/public/gtk/WebInputEventFactory.h?r1=19009&r2=19008
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/webkit/api/src/gtk/WebInputEventFactory.cpp?r1=19009&r2=19008

Integrating GtkIMContext into the RenderWidgetHostViewGtk class.This change  
implements signal handers of the GtkIMContext object to support IMEs and  
dead-keys. Also, to improve compatibility with Windows Chrome, this change  
emulates IPC messages sent on Windows when we input characters and fixes  
Issue 13604 as well as Issue 10953 and 11226. Even though I notice we need  
more work for fixing edge cases (e.g. disabling IMEs on a password input)  
on Linux, I think this is the good starting point. (Supporting edge-cases  
requires complicated code and it makes hard to review.)

BUG=10953 "IME support"
BUG=11226 "Dead keys and accents input not working"
BUG=13604 "Hotkeys not working in non-us keyboard layout"
TEST=Open a web page which contains an <input> form (e.g.  
<http://www.google.com/>), type a '[{' key and an 'A' key on a  
Canadian-French keyboard, and see a Latin character "U+00E2" is displayed  
in the <input> form.
TEST=Open a web page which contains an <input> form (e.g.  
<http://www.google.com/>), enable an Chinese Pinyin IME, type a 'W' key,  
type an 'O' key, and see a Chinese character is displayed in the <input>  
form.
TEST=Change the keyboard layout to Hebrew (or Russian), open a web page  
which contains an <input> form, input some characters in the <input> form,  
type control+a, and see the text in the <input> form is selected.
Review URL: http://codereview.chromium.org/126118
------------------------------------------------------------------------


--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings

--~--~---------~--~----~------------~-------~--~----~
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/group/chromium-bugs
-~----------~----~----~----~------~----~------~--~---

Reply via email to