Comment #35 on issue 469 by [email protected]: Support SOCKS proxy
http://code.google.com/p/chromium/issues/detail?id=469

The following revision refers to this bug:
     http://src.chromium.org/viewvc/chrome?view=rev&revision=19474

------------------------------------------------------------------------
r19474 | [email protected] | 2009-06-28 00:58:58 -0700 (Sun, 28 Jun  
2009) | 8 lines
Changed paths:
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/net/net.gyp?r1=19474&r2=19473
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/net/socket/socket_test_util.cc?r1=19474&r2=19473
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/net/socket/socket_test_util.h?r1=19474&r2=19473
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/net/socket/socks_client_socket.cc?r1=19474&r2=19473
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/net/socket/socks_client_socket.h?r1=19474&r2=19473
    A  
http://src.chromium.org/viewvc/chrome/trunk/src/net/socket/socks_client_socket_unittest.cc

Tests for socks4/4a implementation.

Refactoring of void BuildHandshakeWriteBuffer() to const std::string  
BuildHandshakeWriteBuffer() const,and removing private members  
handshake_buf_len_ and buffer_len_ (since buffer_ is now std::string,  
buffer_.size()) is more than sufficient for buffer size.

TEST=unittests
BUG=469

Review URL: http://codereview.chromium.org/139009
------------------------------------------------------------------------


--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings

--~--~---------~--~----~------------~-------~--~----~
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/group/chromium-bugs
-~----------~----~----~----~------~----~------~--~---

Reply via email to