Comment #2 on issue 15467 by [email protected]: Crash on new tab page
with not tips
http://code.google.com/p/chromium/issues/detail?id=15467
The following revision refers to this bug:
http://src.chromium.org/viewvc/chrome?view=rev&revision=19740
------------------------------------------------------------------------
r19740 | [email protected] | 2009-07-01 09:55:15 -0700 (Wed, 01 Jul
2009) | 7 lines
Changed paths:
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/generated_resources.grd?r1=19740&r2=19739
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/dom_ui/new_tab_ui.cc?r1=19740&r2=19739
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/dom_ui/tips_handler.cc?r1=19740&r2=19739
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/dom_ui/tips_handler.h?r1=19740&r2=19739
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/resources/new_new_tab.css?r1=19740&r2=19739
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/resources/new_new_tab.html?r1=19740&r2=19739
Remove null link from "welcome to tips" default suggestion. Also make some
hard-coded strings in new tab page into localizable .grd strings, and fix
bug introduced in r19556.
BUG= http://crbug.com/15467
TEST= Run with new new tab page for the first time, with no tips stored in
preferences. Note that welcome tip is not a link.
Review URL: http://codereview.chromium.org/147247
------------------------------------------------------------------------
--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings
--~--~---------~--~----~------------~-------~--~----~
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/group/chromium-bugs
-~----------~----~----~----~------~----~------~--~---
