Comment #5 on issue 13967 by [email protected]: theme base colors should be picked from system colors http://code.google.com/p/chromium/issues/detail?id=13967
The following revision refers to this bug:
http://src.chromium.org/viewvc/chrome?view=rev&revision=19868
------------------------------------------------------------------------
r19868 | [email protected] | 2009-07-02 17:42:29 -0700 (Thu, 02 Jul 2009) | 18
lines
Changed paths:
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/chrome_dll_main.cc?r1=19868&r2=19867
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/browser_theme_provider.cc?r1=19868&r2=19867
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/browser_theme_provider.h?r1=19868&r2=19867
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/gtk/back_forward_button_gtk.cc?r1=19868&r2=19867
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/gtk/back_forward_button_gtk.h?r1=19868&r2=19867
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/gtk/bookmark_bar_gtk.cc?r1=19868&r2=19867
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/gtk/bookmark_bar_gtk.h?r1=19868&r2=19867
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/gtk/browser_titlebar.cc?r1=19868&r2=19867
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/gtk/browser_toolbar_gtk.cc?r1=19868&r2=19867
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/gtk/browser_toolbar_gtk.h?r1=19868&r2=19867
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/gtk/browser_window_gtk.cc?r1=19868&r2=19867
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/gtk/custom_button.cc?r1=19868&r2=19867
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/gtk/custom_button.h?r1=19868&r2=19867
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/gtk/find_bar_gtk.cc?r1=19868&r2=19867
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/gtk/gtk_chrome_button.cc?r1=19868&r2=19867
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/gtk/gtk_chrome_button.h?r1=19868&r2=19867
A
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/gtk/gtk_theme_provider.cc
A
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/gtk/gtk_theme_provider.h
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/gtk/location_bar_view_gtk.cc?r1=19868&r2=19867
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/gtk/options/content_page_gtk.cc?r1=19868&r2=19867
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/gtk/options/content_page_gtk.h?r1=19868&r2=19867
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/gtk/tabs/tab_renderer_gtk.cc?r1=19868&r2=19867
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/gtk/tabs/tab_strip_gtk.cc?r1=19868&r2=19867
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/profile.cc?r1=19868&r2=19867
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/profile.h?r1=19868&r2=19867
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/chrome.gyp?r1=19868&r2=19867
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/pref_names.cc?r1=19868&r2=19867
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/pref_names.h?r1=19868&r2=19867
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/testing_profile.h?r1=19868&r2=19867
GTK: Initial implementation of using GTK themes, partially based on evan's
CL 118358.
A lot of stuff works:
- Colors are picked out of the GTK theme.
- Buttons use the current GTK button theme.
- We use the user's icon theme.
A lot of stuff doesn't:
- We could do a better job of picking colors for the skylines.
- The omnibox hasn't been touched.
- UI that's not part of the toolbar hasn't been touched.
- We currently fail on themes like HighContrastInverse.
TEST=Under Options>Personal Stuff, click GTK Theme. Colors and widgets
should be rendered with the current GTK theme stuff.
TEST=With chrome open and in GTK Theme mode, change your GTK theme or icon
theme. chrome should pick up on the change immediately and reimport the
colors and images.
http://crbug.com/13967
Review URL: http://codereview.chromium.org/150176
------------------------------------------------------------------------
--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings
--~--~---------~--~----~------------~-------~--~----~
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/group/chromium-bugs
-~----------~----~----~----~------~----~------~--~---
