Comment #10 on issue 10871 by [email protected]: Memory leak in ui_tests'  
RedirectTest.Server
http://code.google.com/p/chromium/issues/detail?id=10871

So it wasn't the task leaking (verified that it does in fact deleted).

Digging deeper, I found the NotificationTask stuffs the GURL into a  
ResourceRedirectDetails*, whose lifespan
is controlled by a scoped_ptr<ResourceRequestDetails>.

The problem is that while ResourceRedirectDetails extends  
ResourceRequestDetails, the dtor on
ResourceRequestDetails is non-virtual. So the extra field (GURL) that  
ResourceRedirectDetails added is not
torn down properly.

I will fix this by (a) making the dtor virtual and (b) fixing up the API to  
take a ResourceRedirectDetails* rather
than a ResourceRequestDetails.
Note that either (a) OR (b) is sufficient to fix the leak, but it seemed  
appropriate to do both.

--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings

--~--~---------~--~----~------------~-------~--~----~
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/group/chromium-bugs
-~----------~----~----~----~------~----~------~--~---

Reply via email to