Comment #2 on issue 16144 by [email protected]: REGRESSION: crash in
Alt404PageResourceFetcher
http://code.google.com/p/chromium/issues/detail?id=16144
The following revision refers to this bug:
http://src.chromium.org/viewvc/chrome?view=rev&revision=20082
------------------------------------------------------------------------
r20082 | [email protected] | 2009-07-07 14:26:25 -0700 (Tue, 07 Jul 2009)
| 13 lines
Changed paths:
M
http://src.chromium.org/viewvc/chrome/trunk/src/webkit/glue/alt_404_page_resource_fetcher.cc?r1=20082&r2=20081
M
http://src.chromium.org/viewvc/chrome/trunk/src/webkit/glue/alt_error_page_resource_fetcher.cc?r1=20082&r2=20081
The WebURLResponse will be null if the network request fails. So, a null
check
here is warranted. I failed to translate this over when adapting this code
to
the new interfaces.
The tight coupling with WebView, WebFrame and WebViewDelegate makes this
code
non-trivial to test. My next patch was anyways to remove those
dependencies.
I'll circle around at that point with some unit tests for these classes.
R=brettw
TEST=none
BUG=16144
Review URL: http://codereview.chromium.org/155166
------------------------------------------------------------------------
--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings
--~--~---------~--~----~------------~-------~--~----~
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/group/chromium-bugs
-~----------~----~----~----~------~----~------~--~---
