Comment #5 on issue 15596 by [email protected]: Crash -  
disk_cache::EntryImpl::Update(disk_cache::EntryImpl *)
http://code.google.com/p/chromium/issues/detail?id=15596

The following revision refers to this bug:
     http://src.chromium.org/viewvc/chrome?view=rev&revision=20067

------------------------------------------------------------------------
r20067 | [email protected] | 2009-07-07 12:47:08 -0700 (Tue, 07 Jul 2009)  
| 14 lines
Changed paths:
    A  
http://src.chromium.org/viewvc/chrome/trunk/src/net/data/cache_tests/dirty_entry2
    A  
http://src.chromium.org/viewvc/chrome/trunk/src/net/data/cache_tests/dirty_entry2/contents.txt
    A  
http://src.chromium.org/viewvc/chrome/trunk/src/net/data/cache_tests/dirty_entry2/data_0
    A  
http://src.chromium.org/viewvc/chrome/trunk/src/net/data/cache_tests/dirty_entry2/data_1
    A  
http://src.chromium.org/viewvc/chrome/trunk/src/net/data/cache_tests/dirty_entry2/data_2
    A  
http://src.chromium.org/viewvc/chrome/trunk/src/net/data/cache_tests/dirty_entry2/data_3
    A  
http://src.chromium.org/viewvc/chrome/trunk/src/net/data/cache_tests/dirty_entry2/index
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/net/disk_cache/backend_impl.cc?r1=20067&r2=20066
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/net/disk_cache/backend_impl.h?r1=20067&r2=20066
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/net/disk_cache/backend_unittest.cc?r1=20067&r2=20066
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/net/disk_cache/entry_impl.cc?r1=20067&r2=20066
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/net/disk_cache/entry_impl.h?r1=20067&r2=20066
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/net/disk_cache/eviction.cc?r1=20067&r2=20066
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/net/disk_cache/rankings.cc?r1=20067&r2=20066

Disk cache: Keep a map of all open entries.

We still have a few crashes when for some reason we believe
an entry is not dirty and we follow the pointer stored by
its rankings node only to crash while accessing the memory.
I have no explanation to why the dirty id matches the current
one (a page boundary issue maybe?), but having a map with all
open entries solves the issue of having to follow pointers
from disk.

BUG=15596, b/1120346
TEST=unittests

Review URL: http://codereview.chromium.org/149218
------------------------------------------------------------------------


--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings

--~--~---------~--~----~------------~-------~--~----~
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/group/chromium-bugs
-~----------~----~----~----~------~----~------~--~---

Reply via email to