Comment #2 on issue 15833 by [email protected]: REGRESSION: Info bar
to make Chrome as default browser is shown after FRUI
http://code.google.com/p/chromium/issues/detail?id=15833
The following revision refers to this bug:
http://src.chromium.org/viewvc/chrome?view=rev&revision=20151
------------------------------------------------------------------------
r20151 | [email protected] | 2009-07-08 09:17:12 -0700 (Wed, 08 Jul
2009) | 2 lines
Changed paths:
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/browser_main.cc?r1=20151&r2=20150
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/first_run.cc?r1=20151&r2=20150
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/first_run.h?r1=20151&r2=20150
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/first_run_gtk.cc?r1=20151&r2=20150
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/first_run_mac.mm?r1=20151&r2=20150
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/first_run_win.cc?r1=20151&r2=20150
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/first_run_view.cc?r1=20151&r2=20150
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/first_run_view.h?r1=20151&r2=20150
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/temp_scaffolding_stubs.h?r1=20151&r2=20150
Some code had been removed from FirstRun::IsChromeFirstRun() so that it may
return true then false when later invoked.This caused a bug where we would
show the info-bar warning that Chromium is not the default browser after
the first run.This patch resurrects that code and changes the first run UI,
as it was relying on that behavior.BUG=http://crbug.com/15833TEST=Make IE
or Firefox your default browser. Open Chromium so it shows the 1st run UI.
Unselect the "make chromium my default browser" button, then press start.
When Chromium shows up, there should be no info-bar warning you Chromium is
not your default browser. Also test that the first run UI still works
as expected.
Review URL: http://codereview.chromium.org/155168
------------------------------------------------------------------------
--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings
--~--~---------~--~----~------------~-------~--~----~
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/group/chromium-bugs
-~----------~----~----~----~------~----~------~--~---
