Updates:
Mergedinto: -10871
Comment #3 on issue 10873 by [email protected]: Memory leak in
ui_tests' RedirectTest.ServerReference
http://code.google.com/p/chromium/issues/detail?id=10873
The following revision refers to this bug:
http://src.chromium.org/viewvc/chrome?view=rev&revision=20179
------------------------------------------------------------------------
r20179 | [email protected] | 2009-07-08 12:03:29 -0700 (Wed, 08 Jul 2009)
| 10 lines
Changed paths:
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/renderer_host/resource_request_details.h?r1=20179&r2=20178
M
http://src.chromium.org/viewvc/chrome/trunk/src/tools/valgrind/suppressions.txt?r1=20179&r2=20178
Fix a leak of the new location GURL by NotificationTask when doing a
redirect.
The problem is scoped_ptr<ResourceRequestDetails> is used to delete an
instance of ResourceRedirectDetails, however the base class's destructor is
non-virtual, so ResourceRedirectDetails extra field (GURL new_url_) does
not get torn down properly.
Note that the blame callstacks in the bug report appear unrelated, because
std::string is doing some fancy refcounting under the hood. So as GURLs get
passed around, they take over the GURL::spec's memory that got allocated
earlier by the network stack.
BUG=http://crbug.com/10873
TEST=The "RedirectTest.*" ui tests when run on linux valgrind bots should
show no leaks
Review URL: http://codereview.chromium.org/155204
------------------------------------------------------------------------
--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings
--~--~---------~--~----~------------~-------~--~----~
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/group/chromium-bugs
-~----------~----~----~----~------~----~------~--~---
