Comment #4 on issue 14139 by [email protected]: Bookmark bar on needs
a new look at
http://code.google.com/p/chromium/issues/detail?id=14139
The following revision refers to this bug:
http://src.chromium.org/viewvc/chrome?view=rev&revision=20244
------------------------------------------------------------------------
r20244 | [email protected] | 2009-07-08 21:45:07 -0700 (Wed, 08 Jul 2009) |
25 lines
Changed paths:
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/nibs/en.lproj/Toolbar.xib?r1=20244&r2=20243
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/bookmark_bar_bridge_unittest.mm?r1=20244&r2=20243
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/bookmark_bar_controller.h?r1=20244&r2=20243
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/bookmark_bar_controller.mm?r1=20244&r2=20243
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/bookmark_bar_controller_unittest.mm?r1=20244&r2=20243
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/bookmark_button_cell.mm?r1=20244&r2=20243
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/browser_window_controller.h?r1=20244&r2=20243
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/browser_window_controller.mm?r1=20244&r2=20243
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/browser_window_controller_unittest.mm?r1=20244&r2=20243
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/toolbar_controller.h?r1=20244&r2=20243
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/toolbar_controller.mm?r1=20244&r2=20243
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/toolbar_controller_unittest.mm?r1=20244&r2=20243
- Fix janklist issue #1: "there is a pixel line below the main
toolbar. The main toolbar should blend in with the bookmark bar when
it's open"
- Fix janklist issue #2: "It's way too tall - the distance from the
bottom of the bar to a bookmark button bottom edge should be the
same as the distance from the omnibox to the bookmark button top
edge (this will probably mean that the bar has to overlap the
toolbar)."
- Fix janklist issue #4 (first part): "the bookmark bar bookmark buttons
have a frame around them ... "
- Fix janklist issue #9: "the show/hide animation is very janky... I see
a dark gray area behind". Even with animators the grey is gone, but
animators are disabled for now due to races.
- Fix unlisted jank related to 9: don't use animator when opening bar on
launch.
- Also chipped away on unit tests.
TEST=Launch with bookmark bar both open and closed. Make sure OK on launch.
In each case open and close a few times fast.
Repeat with multiple windows open.
Sanity check jank descriptions listed above are fixed.
BUG=crbug.com/14139, crbug.com/8381, crbug.com/14724
Review URL: http://codereview.chromium.org/149308
------------------------------------------------------------------------
--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings
--~--~---------~--~----~------------~-------~--~----~
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/group/chromium-bugs
-~----------~----~----~----~------~----~------~--~---
